[d-kernel] Патчи на dts(i) и изменения в DT Bindings // was: Re: [PATCH 2/7] arm64: dts: rockchip: Add SPDIF nodes to RK3588(s) device trees
Ivan A. Melnikov
iv на altlinux.org
Вт Авг 18 13:56:27 MSK 2026
On Wed, Feb 11, 2026 at 12:41:14PM +0400, Daniil Gnusarev wrote:
> From: Alexey Charkov <alchark at gmail.com>
>
> RK3588s has four SPDIF transmitters, and the full RK3588 has six.
> They are software compatible to RK3568 ones. Add respective nodes
> to .dtsi files.
>
> Adapted from vendor sources at [1] and [2], respectively
>
> [1] https://github.com/rockchip-linux/kernel/blob/develop-5.10/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> [2] https://github.com/rockchip-linux/kernel/blob/develop-5.10/arch/arm64/boot/dts/rockchip/rk3588.dtsi
Как будто бы вместе с этим патчем надо брать изменения на binding'и[1],
иначе в dtbs_check появляются новые ошибки:
arch/arm64/boot/dts/edelweiss/rk3588-thin_88rk-1a-001.dtb: spdif-tx at fddb0000 (rockchip,rk3588-spdif): compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml
Однако я вижу, что по традиции при бекпортировании патчей на dts(i) такого
не происходило, и это кажется достаточно разумным, так как изменения
в bindings могут приводить к конфликтам при merge (как и любые изменения),
а на функциональность они не влияют.
Если по этому поводу другие мнения?
--
wbr,
iv m.
Подробная информация о списке рассылки devel-kernel