[devel] [PATCH v4 1/2] Add diff exclude option for gear-rules

[Alexey Gladkov]

On Mon, Dec 07, 2020 at 08:19:25PM +0300, Dmitry V. Levin wrote:
> On Mon, Dec 07, 2020 at 06:07:41PM +0100, Alexey Gladkov wrote:
> > On Mon, Dec 07, 2020 at 07:58:09PM +0300, Dmitry V. Levin wrote:
> > > On Fri, Nov 27, 2020 at 04:44:30PM +0300, Vladimir D. Seleznev wrote:
> [...]
> > > > @@ -376,6 +376,13 @@ get_diff_name()
> > > >  				;;
> > > >  			name=*) diff_name="${opt#name=}"
> > > >  				;;
> > > > +			exclude=*)
> > > > +				[ -z "$(printf %s "${opt#exclude=}" |tr -d '[:alnum:]_.?*-/![]')" ] ||
> > > > +					rules_error "Invalid diff exclude pattern specified: ${opt#exclude=}"
> > > 
> > > Why '[:alnum:]_.?*-/![]' ?
> > 
> > because glob patterns have these symbols.
> 
> This doesn't match the pattern check in extract_pattern(),
> should it be updated?

This is a different issue. I told you about this on November 26, 2020.

> Would it be useful to have a single definition of this set somewhere?

Yep.

-- 
Rgrds, legion