[devel] [PATCH for apt 02/38] Use correct types and type specifiers

[Dmitry V. Levin]

On Wed, Dec 11, 2019 at 10:56:36AM +0300, Aleksei Nikiforov wrote:
> 11.12.2019 1:45, Dmitry V. Levin пишет:
> > On Tue, Dec 10, 2019 at 06:23:07PM +0300, Aleksei Nikiforov wrote:
> >> Found via cppcheck
> >> ---
> >>   apt/apt-pkg/contrib/cdromutl.cc | 4 ++--
> >>   apt/apt-pkg/contrib/strutl.cc   | 8 ++++----
> >>   apt/cmdline/acqprogress.cc      | 4 ++--
> >>   apt/methods/connect.cc          | 4 ++--
> >>   apt/methods/http.cc             | 9 +++------
> >>   apt/methods/http.h              | 2 +-
> >>   6 files changed, 14 insertions(+), 17 deletions(-)
> > 
> > It would be great if you included the cppcheck diagnostics as well,
> > you can use the following commit as an example:
> > https://gitlab.com/strace/strace/commit/2b64854e
> 
> So, should such blankets of text be added for each fixed line? Commit 
> messages would become much bigger than commits themselves in that case 
> for a lot of commits considering multiline messages and one-line fixes. 
> Is it really needed considering fixes are already grouped in commits by 
> type?

Let's use common sense.  If both the bug and the fix are obvious, there is
no need to add anything.  Otherwise, group all fixes by the kind of bug
being fixed and include a single diagnostic message, e.g. the first
diagnostic message of the series.


-- 
ldv