[devel] [PATCH 0/8] rpm: cleanup set.c and set.h

[Alexey Tourbin]

On Mon, Nov 22, 2010 at 09:14:50AM +0200, Kirill A. Shutemov wrote:
> On Mon, Nov 22, 2010 at 08:40:46AM +0300, Alexey Tourbin wrote:
> > On Tue, Nov 16, 2010 at 05:56:34PM +0200, Kirill A. Shutsemov wrote:
> > > Let's try to make set-versions implementation more maintainable.
> > > 
> > > Kirill A. Shutemov (8):
> > >   set.c, set.h: get rid of C++-style comments
> > >   set.c: get rid of nested functions
> > 
> > I reckon most of these changes aren't necessary.
> Cleanup is never necessary.

"Cleanup" is inappropriate term here, along with "more maintainable".
Rather, the code in question could be "more portable".  E.g. nested
functions are non-portable.  But I find them convenient.

Thus I choose to sacrifice portability for convenience - I see no reason
to stick to c89, as long as gcc itself is portable.

> > This is my coding style, and yes, I use -std=gnu99 features.
> Ok. Pushed to git. Just in case.