[d-kernel] [PATCH] AltHa: nosuid handles capabilities as well

Vitaly Chikunov vt на altlinux.org
Пн Май 9 14:47:07 MSK 2022


Vladimir,

On Fri, May 06, 2022 at 02:45:36AM +0300, Vladimir D. Seleznev wrote:
> On Thu, May 05, 2022 at 06:55:05PM +0300, Vitaly Chikunov wrote:
> 
> > On Thu, Apr 28, 2022 at 02:59:55PM +0000, Vladimir D. Seleznev wrote:
> > [skip]
> > 
> >   CC      security/altha/altha_lsm.o
> > security/altha/altha_lsm.c: In function 'altha_bprm_creds_from_file':
> > security/altha/altha_lsm.c:284:32: error: unused variable 'cur_euid' [-Werror=unused-variable]
> >   284 |                 uid_t cur_uid, cur_euid;
> >       |                                ^~~~~~~~
> > cc1: all warnings being treated as errors
> > make[2]: *** [scripts/Makefile.build:277: security/altha/altha_lsm.o] Error 1
> > make[1]: *** [scripts/Makefile.build:540: security/altha] Error 2
> > make: *** [Makefile:1868: security] Error 2
> > make: *** Waiting for unfinished jobs....
> 
> Hmm, interesting. My build is OK. I'll see on this tomorrow.

While you will look at it tomorrow, please also add minimal tests, for
positive and negative case, also preferable make them self-contained
enough to be runnable in vm-run. Example of the test in
  security/kiosk/kiosk-test.sh

Thanks,

> 
> -- 
>    WBR,
>    Vladimir D. Seleznev
> _______________________________________________
> devel-kernel mailing list
> devel-kernel at lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel-kernel


Подробная информация о списке рассылки devel-kernel